Skip to content

ci: repin dtolnay/rust-toolchain to the rewritten stable commit - #775

Closed
techgopal wants to merge 1 commit into
mainfrom
fix/rust-toolchain-repin
Closed

ci: repin dtolnay/rust-toolchain to the rewritten stable commit#775
techgopal wants to merge 1 commit into
mainfrom
fix/rust-toolchain-repin

Conversation

@techgopal

@techgopal techgopal commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

dtolnay/rust-toolchain's stable branch was rewritten on 2026-11-15 at 02:32 UTC. The pinned commit b725eda5 no longer has history in that repository, so zizmor's impostor-commit audit fails on every PR that touches a workflow (seen on #769 and #774). zizmor is a required check.

This repins the four uses (.github/actions/setup-rust/action.yml x2, binaries.yml, docs-site.yml) to the current stable head 39008827. Upstream's action.yml is byte-identical at both commits, so the steps behave the same.

Verified: local zizmor .github reports no findings (1 ignored, 99 suppressed).

CI/infra only; no Rust changes.

@techgopal
ci: repin dtolnay/rust-toolchain to the rewritten stable commit
ce85e1a 
dtolnay/rust-toolchain's `stable` branch was rewritten on 2026-11-15
02:32 UTC. The pinned commit b725eda5 no longer has history in that
repository, so zizmor's impostor-commit audit now fails on every PR that
touches a workflow (#769, #774). Repin the four uses (setup-rust action,
binaries, docs-site) to the current `stable` head 39008827. Its
action.yml is byte-identical to the old pin's, so the steps behave the
same.

Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-15T05:03:35.945471Z
We couldn’t complete this review. Comment @codex review to try again.		 ce85e1a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 62a1bab and ce85e1a.

Files selected for processing: 3

  • .github/actions/setup-rust/action.yml
  • .github/workflows/binaries.yml
  • .github/workflows/docs-site.yml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@techgopal techgopal added the no-changelog CI or docs only: no changelog fragment needed label Nov 15, 2026
@codecov

codecov Bot commented Nov 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@techgopal

techgopal commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@techgopal

techgopal commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@techgopal techgopal mentioned this pull request Nov 15, 2026
Merged
@techgopal

techgopal commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

Diff review passed. Independent review of ce85e1a: all four dtolnay/rust-toolchain pins under .github/ are moved to 39008827 (upstream stable head, authored by David Tolnay 2026-11-15T02:32Z); action.yml blob 62252504 is identical at both commits; the diff is the four one-line swaps only.

@techgopal
techgopal added this pull request to the merge queue Nov 15, 2026
@techgopal

techgopal commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

Diff review passed (Opus, head ce85e1a): all 4 dtolnay/rust-toolchain uses in .github/ repinned to 39008827e6b4 (head of upstream stable, not an impostor); the toolchain and components inputs exist at that commit; no other changes. No findings.

@techgopal techgopal mentioned this pull request Nov 15, 2026
Open
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 15, 2026
@techgopal
techgopal added this pull request to the merge queue Nov 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 15, 2026
@techgopal techgopal mentioned this pull request Nov 15, 2026
Open
@techgopal

techgopal commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

Superseded: this repin landed in #776 (merged 09:20 UTC).

@techgopal techgopal closed this Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

no-changelog CI or docs only: no changelog fragment needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@techgopal